Replace std::error::Error with core::error::Error
#116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hash/src/lib.rs
Outdated
| @@ -95,7 +95,7 @@ pub enum ParseHashError { | |||
| } | |||
|
|
|||
| #[cfg(feature = "std")] | |||
pubkey/src/lib.rs
Outdated
| @@ -361,7 +361,7 @@ impl FromPrimitive for ParsePubkeyError { | |||
| } | |||
|
|
|||
| #[cfg(feature = "std")] | |||
pubkey/src/lib.rs
Outdated
| @@ -103,7 +103,7 @@ impl FromPrimitive for PubkeyError { | |||
| } | |||
|
|
|||
| #[cfg(feature = "std")] | |||
instruction/src/error.rs
Outdated
| @@ -442,7 +442,7 @@ pub enum LamportsError { | |||
| } | |||
|
|
|||
| #[cfg(feature = "std")] | |||
instruction/src/error.rs
Outdated
| @@ -243,7 +243,7 @@ pub enum InstructionError { | |||
| } | |||
|
|
|||
| #[cfg(feature = "std")] | |||
instruction/src/error.rs
Outdated
| @@ -243,7 +243,7 @@ pub enum InstructionError { | |||
| } | |||
|
|
|||
| #[cfg(feature = "std")] | |||
| impl std::error::Error for InstructionError {} | |||
| impl core::error::Error for InstructionError {} | |||
|
|
|||
| #[cfg(feature = "std")] | |||
There was a problem hiding this comment.
this is also can be omitted, because this is a core::fmt::Dispalay trait
There was a problem hiding this comment.
Okay, I originally considered dropping these attributes, but I wasn't sure. Thank you for confirming.
* CI: Add powerset clippy check As pointed out in anza-xyz#108, we don't explicitly check for all combinations of features in the sdk, and more specifically, we miss warnings. Add a CI step to run `cargo clippy -- --deny=warnings` on the powerset of features in the sdk. Currently, this means 888 different crate builds, but most of them are quite short. Let's see how long it takes to run in CI to see if it's worth adding. Also, fix some little issues that came up while running this. * Oops, also install clippy * Also fixup the name of the cache key * Remove the bincode requirement for `SlotHashesSysvar` * Fixup signature error
#### Problem Rust v1.85.1 is now available, but the sdk repo is still on 1.84.1 #### Summary of changes Bump the version declared in rust-toolchain.toml
* CI: Remove nightly check, add more to hack check #### Problem We've been adding a lot of new CI steps to the SDK, but some of them might be redundant, causing us to use more CI resources than necessary. For example, we run `./cargo nightly check` and `./cargo nightly hack check`. Are both of those really necessary? #### Summary of changes Remove the nightly check CI job and script, and add some of those features and flags to the hack check. NOTE: I'm not 100% sure about this, so let me know what you think! * Rename hack step to check for simplicity
|
Rebased the last few commits and removed the feature attributes for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply replaces instances of
std::error::Errorwithcore::error::Error. It fixes #81, but as mentioned in the issue, it should probably be merged after #115.Regards,
Divya.